Changes between Initial Version and Version 1 of Ticket #1812, comment 7


Ignore:
Timestamp:
2012-12-27T22:40:45Z (12 years ago)
Author:
Zancas
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1812, comment 7

    initial v1  
    11I've reviewed these changes and run the unittests they include.
     2
    23I concur that the doubled "BB" suffix now correctly raises a {{{ValueError}}}.
    34
    4 I concur that Tera-, Peta-, and Exa-bytes are now correctly handled as scales of 2^40^, 2^50^, and 2^60^.
     5I concur that Tera-, Peta-, and Exa-bytes are now correctly handled as scales of 2^40^, 2^50^, and 2^60^ respectively.
     6
    57I note that the "{{{^}}}" in the "pattern" argument to re.match is not strictly necessary, but assert that it is correct, and may enhance readability.
    68
    7 I do not understand why the suffix's "I" and "i" are to be handled as they are, it seems to me that the pattern e.g. "iB", is an error, but it's plausible I'm simply unfamiliar with established convention.
     9I do not understand why the suffix's "I" and "i" are to be handled as they are.
     10
     11It seems to me that patterns that contain only "I", "i", or e.g. "iB", are errors, but it's plausible I'm simply unfamiliar with established convention.