Changes between Initial Version and Version 1 of Ticket #1921, comment 4


Ignore:
Timestamp:
2013-11-21T22:47:40Z (10 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1921, comment 4

    initial v1  
    1 I believe this was fixed in commits 4cd54e36 ("leasedb/accounting crawler: only treat stable shares as disappeared or unleased") and 9ebc0e8b ("!OpenStack: fix a type error introduced by the fix to #1921") on the 1909-cloud-openstack branch. Note that this is ''not'' on the 1818-leasedb branch, and in general I need to review all patches on 1909-cloud-openstack to see whether they are applicable to 1818-leasedb. I have just noted this on #1818.
     1I believe this was fixed in commits 4cd54e36 ("leasedb/accounting crawler: only treat stable shares as disappeared or unleased") and 9ebc0e8b ("!OpenStack: fix a type error introduced by the fix to #1921") on the 1909-cloud-openstack branch. Note that this is ''not'' on the 1818-leasedb branch, and in general I need to review all patches on ~~1909-cloud-openstack~~ 1819-cloud-merge to see whether they are applicable to 1818-leasedb. I have just noted this on #1818.
    22
    33The problem was indeed not specific to !OpenStack (or the cloud backend). The leasedb design doc had the correct design, which was for the accounting crawler to treat shares in states other than STABLE as leased, but that requirement had been missed in the implementation. That reminds me that we need better tests for edge cases in the accounting crawler.