Changes between Initial Version and Version 1 of Ticket #1928, comment 4


Ignore:
Timestamp:
2014-09-26T23:17:25Z (10 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1928, comment 4

    initial v1  
    33
    44warner wrote on that ticket:
    5 >  Hrm, I thought we'd fixed all of the href targets and form/button targets to use relative URLs. Originally there were lots of absolute URLs (which caused exactly this problem: we had some !AllMyData servers that basically reverse-proxied requests into a localhost:3456 URL, and every once in a while the internal host+port would leak). I remember that some of the absolute URLs were not easy to fix (but I don't remember the reasons right now).
     5> Hrm, I thought we'd fixed all of the href targets and form/button targets to use relative URLs. Originally there were lots of absolute URLs (which caused exactly this problem: we had some !AllMyData servers that basically reverse-proxied requests into a localhost:3456 URL, and every once in a while the internal host+port would leak). I remember that some of the absolute URLs were not easy to fix (but I don't remember the reasons right now).
    66>
    77> Nothing should be getting updated with JS.. it should all be the responsiblity of the HTML-generating code in [source:src/allmydata/web/directory.py].