Changes between Initial Version and Version 1 of Ticket #2049, comment 24


Ignore:
Timestamp:
2014-09-25T19:55:04Z (10 years ago)
Author:
nejucomo
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2049, comment 24

    initial v1  
    33In my opinion, the {{{master.cfg}}} should be minimal, and I'd like to move some of the operations here into {{{packaging-tests}}}, and here are some examples of why:
    44
    5 * In [https://github.com/tahoe-lafs/buildbot-config-tahoe/blob/master/tahoe/git/master.cfg#L92 master.cfg line 92] there's a conditional on a per-buildslave option {{{do_test_already_have_dep}}} which determines whether or not to run a test. I would rather have two explicitly named tests such as {{{test_tahoe_build_with_preexisting_pycryptopp}}} versus {{test_tahoe_build_without_preexisting_pyrcryptopp}}} and then configure buildslaves by specifying which tests they run.  (In fact, a single buildslave may be able to run both tests which would be handy especially when we have few buildslaves for a given architecture.)
     5* In [https://github.com/tahoe-lafs/buildbot-config-tahoe/blob/master/tahoe/git/master.cfg#L92 master.cfg line 92] there's a conditional on a per-buildslave option {{{do_test_already_have_dep}}} which determines whether or not to run a test. I would rather have two explicitly named tests such as {{{test_tahoe_build_with_preexisting_pycryptopp}}} versus {{{test_tahoe_build_without_preexisting_pyrcryptopp}}} and then configure buildslaves by specifying which tests they run.  (In fact, a single buildslave may be able to run both tests which would be handy especially when we have few buildslaves for a given architecture.)
    66
    7 ... (I will edit this comment to write more detail, but I want to submit now because I'm paranoid of losing my progress...)
     7* In [https://github.com/tahoe-lafs/buildbot-config-tahoe/blob/master/tahoe/git/master.cfg#L97 master.cfg line 97] we run {{{./setup.py build}}}, which precludes tests such as "run {{{pip install .}}} on a git checkout inside of a virtualenv and verify this works".
     8
     9-etc...
     10
     11I'm a bit confused though about how buildslave's are or should be configured though.  For the short term (for the purposes of this ticket), my goal is to change {{{master.cfg}}} minimally.
     12
     13**edit:** I wrote this comment with multiple submissions because I'm paranoid of killing my browser tab when I really mean "delete previous word", ie: ctrl-w.  :-/