Changes between Initial Version and Version 1 of Ticket #2235, comment 28


Ignore:
Timestamp:
2014-08-21T08:52:51Z (10 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2235, comment 28

    initial v1  
    22> Pull request [https://github.com/tahoe-lafs/tahoe-lafs/pull/100] has a [https://github.com/tahoe-lafs/tahoe-lafs/commit/abece3d27aab9edc491ba477a9f160a089837893 test] and is now ready for review.
    33
    4 Please hold off merging this; there are instances of `os.path.abspath` and `os.path.expanduser` that don't go through `fileutil.abspath_expanduser.unicode` and should be changed to do so. That includes the call in `fileutil.put_file` that motivated this ticket, so the pull request doesn't actually fix the bug. See the results of `egrep -Rn --include='*.py' 'expanduser|abspath' src |grep -v abspath_expanduser_unicode` for other cases.
     4Please hold off merging this; there are instances of `os.path.abspath` and `os.path.expanduser` that don't go through `fileutil.abspath_expanduser.unicode` and should be changed to do so. That includes the call in `fileutil.put_file` that motivated this ticket, so the pull request doesn't actually fix the bug. See the results of `egrep -Rn --include='*.py' 'expanduser|abspath' src |egrep -v 'abspath_expanduser_unicode|argv_to_abspath` for other cases.