| 1 | | {{{ |
| 2 | | (2014-09-23 18:49:52) zooko: Does anybody know why coveralls say that coverage decreased here? https://github.com/tahoe-lafs/tahoe-lafs/pull/110#issuecomment-56559949 |
| 3 | | (2014-09-23 18:50:02) zooko: Better yet, can I find a diff of coverage before and after that PR? |
| 4 | | (2014-09-23 18:50:36) warner: the coveralls site shows which files are up/down (or both at the same time, weirdly) |
| 5 | | (2014-09-23 18:50:52) warner: it's not as readable as it could be |
| 6 | | (2014-09-23 18:51:16) ***zooko looks at https://coveralls.io/builds/1246883 |
| 7 | | (2014-09-23 18:51:38) zooko: So this page https://coveralls.io/builds/1246883 is all about this one PR. |
| 8 | | (2014-09-23 18:53:26) warner: looks like 5 lines in mutable/publish.py .. |
| 9 | | (2014-09-23 18:53:50) ***zooko looks at https://coveralls.io/files/297721106 |
| 10 | | (2014-09-23 18:54:03) warner: urgh, it shows which lines are covered/uncovered, and how many changed, but it doesn't say *which* lines changed |
| 11 | | (2014-09-23 18:54:16) zooko: Oh cool there's a button to "previous job": https://coveralls.io/files/290358568 |
| 12 | | (2014-09-23 18:54:23) zooko: Now I flip back and forth until I see it... :-) |
| 13 | | (2014-09-23 18:55:10) zooko: line 451 |
| 14 | | (2014-09-23 18:55:23) zooko: That's 3 of the lines ... |
| 15 | | (2014-09-23 18:55:29) warner: one job had some bad shares, the other didn't |
| 16 | | (2014-09-23 18:55:31) zooko: This process of spotting the difference needs automation. :-( |
| 17 | | (2014-09-23 18:55:35) warner: yeah |
| 18 | | (2014-09-23 18:55:49) warner: two more lines at 496 |
| 19 | | (2014-09-23 18:55:59) warner: which is the same thing, lack of bad shares |
| 20 | | (2014-09-23 18:56:17) warner: what did the PR change? |
| 21 | | }}} |
| | 1 | > zooko: Does anybody know why coveralls say that coverage decreased here? https://github.com/tahoe-lafs/tahoe-lafs/pull/110#issuecomment-56559949 |
| | 2 | |
| | 3 | > zooko: Better yet, can I find a diff of coverage before and after that PR? |
| | 4 | |
| | 5 | > warner: the coveralls site shows which files are up/down (or both at the same time, weirdly) |
| | 6 | |
| | 7 | > warner: it's not as readable as it could be |
| | 8 | |
| | 9 | > ***zooko looks at https://coveralls.io/builds/1246883 |
| | 10 | |
| | 11 | > zooko: So this page https://coveralls.io/builds/1246883 is all about this one PR. |
| | 12 | |
| | 13 | > warner: looks like 5 lines in mutable/publish.py .. |
| | 14 | |
| | 15 | > ***zooko looks at https://coveralls.io/files/297721106 |
| | 16 | |
| | 17 | > warner: urgh, it shows which lines are covered/uncovered, and how many changed, but it doesn't say *which* lines changed |
| | 18 | |
| | 19 | > zooko: Oh cool there's a button to "previous job": https://coveralls.io/files/290358568 |
| | 20 | |
| | 21 | > zooko: Now I flip back and forth until I see it... :-) |
| | 22 | |
| | 23 | > zooko: line 451 |
| | 24 | |
| | 25 | > zooko: That's 3 of the lines ... |
| | 26 | |
| | 27 | > warner: one job had some bad shares, the other didn't |
| | 28 | |
| | 29 | > zooko: This process of spotting the difference needs automation. :-( |
| | 30 | |
| | 31 | > warner: yeah |
| | 32 | |
| | 33 | > warner: two more lines at 496 |
| | 34 | |
| | 35 | > warner: which is the same thing, lack of bad shares |
