Opened at 2015-03-10T17:07:36Z
Closed at 2021-01-05T20:54:46Z
#2389 closed enhancement (wontfix)
try switching from coveralls.io to codecov.io
Reported by: | daira | Owned by: | daira |
---|---|---|---|
Priority: | normal | Milestone: | soon (release n/a) |
Component: | dev-infrastructure | Version: | 1.10.0 |
Keywords: | coverage tests | Cc: | |
Launchpad Bug: |
Description
The codecov.io reports apparently include branch coverage, which I consider essential, but coveralls does not support. The changes needed seem completely straightforward.
The only disadvantage would be that the historical coverage data wouldn't be copied across, but I think that's fine.
Change History (10)
comment:1 Changed at 2015-03-10T17:19:33Z by zooko
comment:2 Changed at 2015-03-12T18:28:49Z by daira
- Resolution set to wontfix
- Status changed from new to closed
"This application will be able to read and write all public and private [github] repo data."
Scratch that then.
comment:3 Changed at 2020-12-29T17:52:47Z by exarkun
https://www.tahoe-lafs.org/trac/tahoe-lafs/ticket/3385 was a duplicate of this.
comment:4 Changed at 2020-12-29T17:57:34Z by exarkun
coveralls.io no longer requests the "repo" scope (I believe that is the scope that corresponds to the description "This application will be able to read and write all public and private [github] repo data.".
Instead, it requests:
- Read org and team membership, read org projects
- Access commit status
- Access user email addresses (read-only)
This is substantially less invasive so it seems reasonable to consider this switch again.
My current interest stems from codecov behavior of reporting results early, before all jobs have run, which invariably makes the report look extremely bad. I've tried fixing this with "wait_for_ci: true" (https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3568) but to no avail.
comment:5 Changed at 2020-12-29T17:57:38Z by exarkun
- Resolution wontfix deleted
- Status changed from closed to reopened
comment:6 Changed at 2020-12-29T20:15:12Z by exarkun
Here's a setback. To support collecting coverage data from more than one job, you need to manually deliver a "finished" notification to coveralls.io. With some annoying manual work it's possible to do this correctly for _either_ CircleCI _or_ GitHub? Actions but delivering the finished hook only after _both_ CI providers are done is a lot harder.
I guess you'd need a job on one of them that could find the corresponding jobs on the other and wait? And only after that job (and all other local jobs) finish would you deliver the finished notification.
I don't feel like working on this any more today.
comment:7 Changed at 2020-12-29T20:16:09Z by exarkun
For reference https://docs.coveralls.io/parallel-build-webhook
comment:8 Changed at 2020-12-29T20:19:19Z by exarkun
Aha. I just realized I read the ticket summary backwards. sigh.
comment:9 Changed at 2020-12-29T20:22:04Z by exarkun
coveralls.io has branch coverage reporting now. It's not ideal but all the information seems to be there, at least.
comment:10 Changed at 2021-01-05T20:54:46Z by exarkun
- Resolution set to wontfix
- Status changed from reopened to closed
Alright I've made enough of a mess on this ticket already, I'm going to close it again, sorry about the noise.
When doing this, please see if you can figure out how to elicit information about *which lines had changes in their coverage* between versions. Coveralls just reports the *change in the number of lines that are covered*, which is not really useful information.