Changes between Initial Version and Version 5 of Ticket #2433


Ignore:
Timestamp:
2015-05-27T00:05:11Z (10 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2433

    • Property Status changed from new to closed
    • Property Component changed from unknown to code
    • Property Priority changed from normal to minor
    • Property Milestone changed from undecided to 1.10.1
    • Property Keywords cleanup dead-code added
    • Property Resolution changed from to fixed

  • Ticket #2433 – Description

    initial v5  
    11Looking at #2432, I noticed that [source:trunk/src/allmydata/util/fileutil.py?annotate=blame&rev=143af6151800efd8ecb750e682aa42da254ce5a7#L90 NamedTemporaryDirectory] is unused except for [source:trunk/src/allmydata/test/test_util.py?annotate=blame&rev=4794666df619fbfd7d36620163b51bda31322773#L434 its unit test].
    22
    3 Now, [https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/src/allmydata/test/test_util.py?annotate=blame&rev=4794666df619fbfd7d36620163b51bda31322773#L434 the newer version of NamedTemporaryDirectory] over in pyutil has an added feature — automatically call `.close()` on children when shutting down — which might be useful on Windows, but probably isn't. In any case, let's remove this older and unused version of `NamedTemporaryDirectory` from Tahoe-LAFS™.
     3Now, [//trac/pyutil/browser/trunk/pyutil/fileutil.py?rev=254#L137 the newer version of NamedTemporaryDirectory] over in pyutil has an added feature — automatically call `.close()` on children when shutting down — which might be useful on Windows, but probably isn't. In any case, let's remove this older and unused version of `NamedTemporaryDirectory` from Tahoe-LAFS™.