Changes between Initial Version and Version 1 of Ticket #2535, comment 2


Ignore:
Timestamp:
2015-10-14T11:13:27Z (9 years ago)
Author:
daira
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2535, comment 2

    initial v1  
    1 I don't think it uses the original uploader's permissions. It uses `fileutil.write` ([https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.3/src/allmydata/frontends/magic_folder.py#L583 here]), which uses whatever the default is for `open(path, "wb")` ([https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.3/src/allmydata/util/fileutil.py#L227 here]). But it does this as the node process, which might not have the same umask as the user's shell (ISTR that twistd changes the umask).
     1I don't think it uses the original uploader's permissions. It uses `fileutil.write` ([https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.3/src/allmydata/frontends/magic_folder.py#L583 here]), which uses whatever the default is for `open(path, "wb")` ([https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.3/src/allmydata/util/fileutil.py#L227 here]). But it does this as the daemonised node process, which might not have the same umask as the user's shell (ISTR that twistd changes the umask).