Changes between Initial Version and Version 1 of Ticket #393, comment 169


Ignore:
Timestamp:
2011-09-25T05:18:43Z (13 years ago)
Author:
davidsarah
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #393, comment 169

    initial v1  
    11Replying to [comment:165 davidsarah]:
    2 > However nothing in publish.py removes entries from {{{self.outstanding}}}. In finish_publishing at [source:src/allmydata/mutable/publish.py@5280#L855], the loop adds entries to {{{self.outstanding}}}, and registers an errback to {{{self._connection_problem}}} if {{{writer.finish_publishing}}} fails. But {{{self._connection_problem}}} removes the writer from {{{self.writers}}}, it doesn't remove {{{(writer.peerid, writer.shnum)}}} from {{{self.outstanding}}}. So either the comment or the logic is wrong.
     2> However nothing in publish.py removes entries from {{{self.outstanding}}}. In finish_publishing at [source:src/allmydata/mutable/publish.py@5280#L855], the loop adds entries to {{{self.outstanding}}}, and registers an errback to {{{self._connection_problem}}} if {{{writer.finish_publishing}}} fails. But {{{self._connection_problem}}} removes the writer from {{{self.writers}}}, it doesn't remove {{{(writer.peerid, writer.shnum)}}} from {{{self.outstanding}}}. So either the comment or the logic is wrong. (Also there's a reference to {{{_loop}}} at line 872, and I don't see any {{{_loop}}} in that file.)
    33
    4 This was fixed in [changeset:f94eb86fc9232ce6]
    5 
    6 > (Also there's a reference to {{{_loop}}} at line 872, and I don't see any {{{_loop}}} in that file.)
    7 
    8 and this in [changeset:1fa5c729b758776b].
     4These were fixed in [changeset:f94eb86fc9232ce6].