Changes between Version 2 and Version 3 of Ticket #637


Ignore:
Timestamp:
2009-10-25T17:40:41Z (15 years ago)
Author:
zooko
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #637 – Description

    v2 v3  
    11This patch [changeset:2e45619844cb7c36] makes it so that if we don't know how to find out the free disk space on a platform, we fall back gracefully by display something like "I dunno" instead of the free disk space.  We also already have code (before that patch) which falls back gracefully in the sense of emitting a warning at startup if the {{{reserved_space}}} feature has been configured (see [src:doc/configuration.txt]) and the current platform can't figure out how much free disk space it has.
    22
    3 However, rather than having such fallbacks, I would really rather just ensure that Tahoe figures out how much free disk space it has on all supported platforms.  For Windows (the only platform which currently does work using {{{statvfs}}}), the way to do that is to require {{{pywin32}}}, {{{import win32api}}}, and call {{{win32api.GetDiskFreeSpaceEx()}}}
     3However, rather than having such fallbacks, I would really rather just ensure that Tahoe figures out how much free disk space it has on all supported platforms.  For Windows (the only platform which currently does not work using {{{statvfs}}}), the way to do that is to require {{{pywin32}}}, {{{import win32api}}}, and call {{{win32api.GetDiskFreeSpaceEx()}}}
    44
    55http://docs.activestate.com/activepython/2.5/pywin32/win32api__GetDiskFreeSpaceEx_meth.html