Changes between Initial Version and Version 1 of Ticket #653, comment 14


Ignore:
Timestamp:
2013-06-25T16:11:33Z (8 years ago)
Author:
zooko
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #653, comment 14

    initial v1  
    11I spoke with Brian on IRC this morning before his gallivanting schedule, and he said that it was unlikely that this problem will recur with the current versions of foolscap and of TahoeLAFS.  I agree and am going to bump this ticket out of the v1.5 Milestone.
    22
    3 Note that we can't actually close this ticket yet because there isn't a test for the original issue: duplicate entries in {{{IntroducerClient._connections}}} because ~RemoteReferences don't compare equal when they denote the same underlying TCP connection to the same peer, much less the newly discussed issue: duplicate ~RemoteReferences because (somehow) the peer is setting up new ~RemoteReferences while {{{notifyOnDisconnect()}}} is not getting called for the old ones.
     3Note that we can't actually close this ticket yet because there isn't a test for the original issue: duplicate entries in {{{IntroducerClient._connections}}} because !RemoteReferences don't compare equal when they denote the same underlying TCP connection to the same peer, much less the newly discussed issue: duplicate !RemoteReferences because (somehow) the peer is setting up new !RemoteReferences while {{{notifyOnDisconnect()}}} is not getting called for the old ones.
    44
    55However, I'm fairly confident that this is (a) not a regression versus TahoeLAFS v1.4.1, and (b) not a critical bug.  (In fact, it might actually be already fixed in current trunk.)