Changes between Version 1 and Version 2 of Ticket #671, comment 21


Ignore:
Timestamp:
2013-10-14T22:38:10Z (11 years ago)
Author:
zooko
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #671, comment 21

    v1 v2  
    11markberger, first of all, thanks for the patch!
    22
    3 I've been reviewing it (diff against [72b49750d95b0ca01321e8cd0e2bc93cd0c71165]), and in web/storage.py, in StorageStatus.render_JSON, the bucket-counter element is changed to always return None. While this appears to be for compatibility reasons when looking at the context, it might be wise to clarify as such in a comment :)
     3I've been reviewing it (diff against [https://github.com/markberger/tahoe-lafs/tree/72b49750d95b0ca01321e8cd0e2bc93cd0c71165 72b49750d95b0ca01321e8cd0e2bc93cd0c71165]), and in web/storage.py, in !StorageStatus.render_JSON, the bucket-counter element is changed to always return None. While this appears to be for compatibility reasons when looking at the context, it might be wise to clarify as such in a comment :)