Changes between Version 4 and Version 5 of MeetingNotes_2012_10_23

Timestamp:

2012-10-24T00:30:54Z (12 years ago)

Author:

davidsarah

Comment:

ref to codepad of modified test that clears the node cache

MeetingNotes_2012_10_23

@@ -32 +32 @@
 amiller shares his terminal, and zooms on test_mutable.py, test_retrieve_surprise.
 
-zooko suggests this test relies on the ResponseCache which the patch has removed; but it's not clear that the test needs to rely on this cache.
+zooko suggests this test relies on the !ResponseCache which the patch has removed; but it's not clear that the test needs to rely on this cache.
 
 * 16:10 - More discussion of the specific test
 
-david-sarah changes "self.old_map.best_recoverable_version()" to (something else) to see a different error and asks if that's the expected error for this test.
+david-sarah changes "self.old_map.best_recoverable_version()" to "n.get_best_readable_version()" to see a different error and asks if that's the expected error for this test.
 
 zooko suggests the current test has four steps:
@@ -63 +63 @@
 zooko suggests a follow-on to ticket 1240 is to review the cache involved in this patch to ensure that it is actually getting hit and justified.
 
-davidsarah modified the test to explicitly clear the node cache, which is what zooko suggested, but the test still does not work and generates the same error.  The old contents are still present which was not expected, so maybe there is yet another cache.
+davidsarah modified the test to explicitly clear the node cache (http://codepad.org/LIj7CF0t), which is what zooko suggested, but the test still does not work and generates the same error.  The old contents are still present which was not expected, so maybe there is yet another cache.
 
-amiller suggests adding prints for object identities to debug the caching behavior further.
+amiller suggests adding prints for object identities to debug the caching behavior further. (This is included in http://codepad.org/LIj7CF0t)
 
 * 16:25 - Zooko discusses topics for next meeting.