Changes between Version 10 and Version 11 of PatchReviewProcess


Ignore:
Timestamp:
2010-07-23T04:49:22Z (11 years ago)
Author:
zooko
Comment:

edit

Legend:

Unmodified
Added
Removed
Modified
  • PatchReviewProcess

    v10 v11  
    2222 4. (optional) Click "accept".  This marks you as the person reviewing this patch.  If you don't want to commit to this then you can skip this step.
    2323 5. Read the patch until you understand the docs, tests, code and comments in it.  You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.
    24   a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might be taken as a reason to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too.
     24  a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might mean that we need to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too, so go ahead and speak up.
    2525  b. Check whether every feature or bugfix in the patch has an accompanying test in the patch.
    26   c. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself.  (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or if you can't think of anyone better then assign it to Zooko.)
     26  c. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself.  (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or "nobody".)
    2727  d. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
    2828  e. Feel good about yourself.  Thank you for helping with our little project attempting to improve the world!