Changes between Version 13 and Version 14 of PatchReviewProcess

Timestamp:

2011-04-03T00:36:14Z (13 years ago)

Author:

zooko

Comment:

tweak how-to-review

PatchReviewProcess

@@ -3 +3 @@
 = Why review patches =
 
-We want more patches to be contributed to Tahoe-LAFS.  Getting  
-feedback on patches encourages contributors.  Patches languishing in  
-the "waiting to be reviewed" state discourages them.  (By the way,  
-something else that encourages them is users saying "Thank you.".)
+We want more patches to be contributed to Tahoe-LAFS.  Patches
+languishing in the "waiting to be reviewed" state discourages 
+contributors. Getting feedback on patches encourages them.
+(By the way, something else that encourages them is users saying 
+"Thank you.".)
 
 = Who can review patches =
@@ -35 +36 @@
 
 Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [http://mumak.net/stuff/your-code-sucks.html Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews].
+
+Two simple suggestions:
+1. Say something nice about the author or their code.
+2. You don't have to be extra picky.