Changes between Version 14 and Version 15 of PatchReviewProcess

Timestamp:

2011-08-01T02:53:01Z (13 years ago)

Author:

nejucomo

Comment:

Make ticket acceptance instructions more explicit.

PatchReviewProcess

@@ -21 +21 @@
  2. You can read everything without registering, but to add comments or change tickets you have to be logged in.  Registering is easy -- click the "Register" link at the top right of the page.
  3. Read tickets until you find one that you can review.
- 4. (optional) Click "accept".  This marks you as the person reviewing this patch.  If you don't want to commit to this then you can skip this step.
+ 4. (optional) Expand "modify ticket" and click "accept", then submit changes.  This marks you as the person reviewing this patch.  If you don't want to commit to this then you can skip this step.
  5. Read the patch until you understand the docs, tests, code and comments in it.  You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.
   a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might mean that we need to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too, so go ahead and speak up.