Changes between Version 15 and Version 16 of PatchReviewProcess

Timestamp:

2011-08-01T03:26:06Z (13 years ago)

Author:

nejucomo

Comment:

Add a section spelling out how to apply patches from tickets.

PatchReviewProcess

@@ -17 +17 @@
 
 = How to review patches =
+
+Here is the overall process for patch review.  For technical tips, see below.
 
  1. Go to http://tahoe-lafs.org .  Click on "[http://tahoe-lafs.org/trac/tahoe/wiki/ViewTickets View Tickets]".  Click on "[query:keywords~=review-needed&status=!closed&group=milestone review-needed]".
@@ -40 +42 @@
 1. Say something nice about the author or their code.
 2. You don't have to be extra picky.
+
+= Technical Tips =
+
+Please suggest improvements here if you run into technical snags while reviewing a ticket.
+
+== Ticket attachment links ==
+
+Attachments in a ticket have two links, a name, which points to an html page with prettification, and a raw download link.  You can save the download link (such as by {{{wget}}}) and use {{{darcs apply}}} to configure your repository to test a particular patch.
+
+For the #1149 ticket, for example, there are two links for the attachment named "test-for-webopen.darcs.patch":
+
+ * The link with a name points here: http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1149/test-for-webopen.darcs.patch
+ * The link with a download icon, here: http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
+
+The latter can be used to apply a patch, like this example shows:
+
+{{{
+$ wget 'http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch'
+--2011-07-31 20:23:39--  http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
+Connecting to 127.0.0.1:8123... connected.
+Proxy request sent, awaiting response... 200 Ok
+Length: 18275 (18K) [text/x-diff]
+Saving to: “test-for-webopen.darcs.patch”
+
+100%[==============================>] 18,275      21.8K/s   in 0.8s    
+
+2011-07-31 20:23:54 (21.8 KB/s) - “test-for-webopen.darcs.patch” saved [18275/18275]
+
+$ darcs apply test-for-webopen.darcs.patch 
+Finished applying...
+}}}