Changes between Version 16 and Version 17 of PatchReviewProcess

Timestamp:

2011-08-31T16:48:53Z (13 years ago)

Author:

zooko

Comment:

move how-to-request-design-review over to how-to-submit-a-patch and note that you don't have to apply the patch or test it to review it

PatchReviewProcess

@@ -31 +31 @@
   e. Feel good about yourself.  Thank you for helping with our little project attempting to improve the world!
 
-= Design reviews =
-
-To request a design review, explain your design (with or without a patch) and then add the [query:keywords~=design-review-needed&status=!closed&group=milestone design-review-needed] tag. Completion of a design review will normally not directly result in a patch being committed. The main goal of a design review is to give the person working on the ticket confidence that there are no show-stopping issues with the approach they are taking, and to get feedback on smaller issues that are useful to take into account before doing further work on a patch.
-
 = Advanced =
 
@@ -49 +45 @@
 == Ticket attachment links ==
 
-Attachments in a ticket have two links, a name, which points to an html page with prettification, and a raw download link.  You can save the download link (such as by {{{wget}}}) and use {{{darcs apply}}} to configure your repository to test a particular patch.
+Attachments in a ticket have two links, a name, which points to an html page with prettification, and a raw download link.  You can save the download link (such as by {{{wget}}}) and use {{{darcs apply}}} to configure your repository to test a particular patch. Note that you do not ''have'' to apply a patch to your local repository or test it in order to review it—often just reading the prettified version on the web is sufficient.
 
 For the #1149 ticket, for example, there are two links for the attachment named "test-for-webopen.darcs.patch":