Changes between Version 17 and Version 18 of PatchReviewProcess

Timestamp:

2011-12-17T01:38:50Z (13 years ago)

Author:

zooko

Comment:

update links and formatting

PatchReviewProcess

@@ -20 +20 @@
 Here is the overall process for patch review.  For technical tips, see below.
 
- 1. Go to http://tahoe-lafs.org .  Click on "[http://tahoe-lafs.org/trac/tahoe/wiki/ViewTickets View Tickets]".  Click on "[query:keywords~=review-needed&status=!closed&group=milestone review-needed]".
+ 1. Go to https://tahoe-lafs.org .  Click on "[wiki:ViewTickets View Tickets]".  Click on "[query:keywords~=review-needed&status=!closed&group=milestone review-needed]".
  2. You can read everything without registering, but to add comments or change tickets you have to be logged in.  Registering is easy -- click the "Register" link at the top right of the page.
  3. Read tickets until you find one that you can review.
@@ -27 +27 @@
   a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might mean that we need to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too, so go ahead and speak up.
   b. Check whether every feature or bugfix in the patch has an accompanying test in the patch.
-  c. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself.  (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or "nobody".)
-  d. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
+  c. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the {{{review-needed}}} keyword from the keywords, and assign the ticket to someone other than yourself.  (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or "nobody".)
+  d. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword {{{review-needed}}}, add the keyword {{{reviewed}}} and assign it to someone with repository write access (currently 'zooko', 'warner', 'davidsarah', and 'kevan'). We'll commit it to trunk.
   e. Feel good about yourself.  Thank you for helping with our little project attempting to improve the world!
 
@@ -49 +49 @@
 For the #1149 ticket, for example, there are two links for the attachment named "test-for-webopen.darcs.patch":
 
- * The link with a name points here: http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1149/test-for-webopen.darcs.patch
- * The link with a download icon, here: http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
+ * The link with a name points here: https://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1149/test-for-webopen.darcs.patch
+ * The link with a download icon, here: https://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
 
 The latter can be used to apply a patch, like this example shows:
 
 {{{
-$ wget 'http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch'
+$ wget 'https://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch'
 --2011-07-31 20:23:39--  http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
 Connecting to 127.0.0.1:8123... connected.