Changes between Version 18 and Version 19 of PatchReviewProcess


Ignore:
Timestamp:
2012-03-31T02:51:38Z (10 years ago)
Author:
zooko
Comment:

more suggestions in "Advanced" patch review

Legend:

Unmodified
Added
Removed
Modified
  • PatchReviewProcess

    v18 v19  
    3535Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [http://mumak.net/stuff/your-code-sucks.html Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews].
    3636
    37 Two simple suggestions:
    38 1. Say something nice about the author or their code.
    39 2. You don't have to be extra picky.
    40 
    41 = Technical Tips =
    42 
    43 Please suggest improvements here if you run into technical snags while reviewing a ticket.
     37A few simple suggestions:
     381. Thank the author for writing the patch.
     392. Say something nice about the author or their code.
     403. You don't have to be extra picky when doing patch review. The goal is just to watch out for bugs or things that would reduce the quality of the codebase.
     414. Write comments about specific parts of the code. This demonstrates that you actually read it carefully enough to understand and care about parts of it, and it makes the author feel good that someone is talking about what they wrote.
    4442
    4543== Ticket attachment links ==