Changes between Version 8 and Version 9 of PatchReviewProcess

Timestamp:

2010-05-19T17:36:39Z (14 years ago)

Author:

zooko

Comment:

write a note saying that you reviewed it

PatchReviewProcess

@@ -24 +24 @@
   a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might be taken as a reason to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too.
   b. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself.  (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or if you can't think of anyone better then assign it to Zooko.)
-  c. If you understand the patch and find no errors or omissions then remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
+  c. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
   d. Feel good about yourself.  Thank you for helping with our little project attempting to improve the world!