Changes between Version 10 and Version 11 of Patches


Ignore:
Timestamp:
2009-06-21T19:22:28Z (16 years ago)
Author:
warner
Comment:

.diff for real diffs looks good, aren't downloadable

Legend:

Unmodified
Added
Removed
Modified

  • Patches

    v10 v11  
    1515
    1616If you don't have darcs or don't want to use it, just attach a normal old diff.
     17
     18== discussion ==
     19
     20If you have an actual diff (as opposed to a darcs patch created with 'darcs send'), then .diff is
     21good, because Trac knows how to render them. At least it does on the attachements I looked at
     22on #684 . I haven't checked to see what a darcs patch file attached with a .diff filename looks like,
     23I think it could get pretty ugly.
     24On the other hand, downloading the diff with "Download Original Format" gets a content-type which firefox
     25insists upon saving instead of displaying. I think I'm ok with that.. what I care about is being able to
     26review the change easily, and Trac's diff markup is pretty good.
     27-warner