Changes between Version 30 and Version 31 of Patches


Ignore:
Timestamp:
2013-08-07T22:03:03Z (11 years ago)
Author:
daira
Comment:

correct test-needed flag

Legend:

Unmodified
Added
Removed
Modified
  • Patches

    v30 v31  
    2020Now that all of the existing unit tests pass, [https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests write your own tests] for the ticket if they don't already exist, and make sure that they pass. Also ensure that `make pyflakes` finds no errors or warnings.
    2121
    22 Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `tests-needed` to the ticket.
     22Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket.
    2323
    2424