Changes between Version 32 and Version 33 of Patches

Timestamp:

2019-03-15T17:30:32Z (6 years ago)

Author:

exarkun

Comment:

The tox environment seems like it should be preferred over the Makefile target

Patches

@@ -18 +18 @@
 Once you think you have solved the issue run the test suite with `tox`. This ensures that you didn't accidentally break something while working on your patch.
 
-Now that all of the existing unit tests pass, [https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests write your own tests] for the ticket if they don't already exist, and make sure that they pass. Also ensure that `make pyflakes` finds no errors or warnings.
+Now that all of the existing unit tests pass, [https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests write your own tests] for the ticket if they don't already exist, and make sure that they pass. Also ensure that `tox -e codechecks` finds no errors or warnings.
 
 Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket.