Changes between Version 35 and Version 36 of Patches
- Timestamp:
- 2020-09-18T18:02:22Z (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Patches
v35 v36 20 20 Now that all of the existing unit tests pass, [https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests write your own tests] for the ticket if they don't already exist, and make sure that they pass. Also ensure that `tox -e codechecks` finds no errors or warnings. 21 21 22 Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag`test-needed` to the ticket.22 Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Please add the keyword `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the keyword `test-needed` to the ticket. 23 23 24 24