Changes between Version 37 and Version 38 of Patches

Timestamp:

2021-04-13T15:00:06Z (3 years ago)

Author:

maylee

Comment:

--

Patches

@@ -22 +22 @@
 You can also use `tox -e codechecks` and `tox -e typechecks` to check for other kinds of errors.
 
-Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Use the [https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review GitHub "request review"] feature to let the team know your PR is ready for a code review.  You should usually request a review from "tahoe-committers" but you can request a review from a specific developer instead if you have good reason to want their review specifically.  If you had trouble with any part of your patch -- don't worry!  Submit the pull request for review anyway and leave a comment describing the area you'd like help with.
+Finally, push your branch to Github and [https://help.github.com/articles/creating-a-pull-request open a pull request]. Write `Fixes ticket:3003` (or whichever your ticket number is) in the merge commit message so when your PR gets approved the `trac` ticket gets closed.  Use the [https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review GitHub "request review"] feature to let the team know your PR is ready for a code review.  You should usually request a review from "tahoe-committers" but you can request a review from a specific developer instead if you have good reason to want their review specifically.  If you had trouble with any part of your patch -- don't worry!  Submit the pull request for review anyway and leave a comment describing the area you'd like help with.
 
 = Design reviews =