Storage Servers version is 0 on Welcome page

[freestorm]

Storage Server version is 0 for all nodes on the Welcome Page.

[freestorm]

I've looked to write a running test , but as far as I Now, the Welcome page in running test dosen't have "fake" storage server to verify version.

Fred

[zooko]

Let's see, to test this we need to exercise the code that the patch changes -- render_service_row() -- and verify that it is emitting something other than 0 in the "version" slot in the ctx. Let's see, there are already pretty thorough tests of the web ui...

Hm, let's see test_web.py test_welcome() might do it, if there is already at least one server connected in that test. Why not see if you can add a requirement that the resulting HTML contains the right pattern of version?

[freestorm]

Replying to zooko:

Let's see, to test this we need to exercise the code that the patch changes -- render_service_row() -- and verify that it is emitting something other than 0 in the "version" slot in the ctx. Let's see, there are already pretty thorough tests of the web ui...

Hm, let's see test_web.py test_welcome() might do it, if there is already at least one server connected in that test. Why not see if you can add a requirement that the resulting HTML contains the right pattern of version?

I can't check the server version with test_web.py test_welcome(), because the running test dosen't have a *fake* server node connected and the test fails.

You can view the test fail ​here

I copy the html code returned from the running test, you can view it ​here

Note: I've just changed the css link, so the page can correctly be viewed by humans

[terrell]

I confirm this patch works as advertised and solves the issue.

[zooko]

fixed in 35ec8f6ac28a4b7b. thanks FreeStorm and terrell!