Opened at 2010-08-02T19:03:48Z
Last modified at 2017-09-19T17:20:49Z
#1148 assigned defect
scripts/startstop_node.py is not tested directly, so can't see coverage
| Reported by: | davidsarah | Owned by: | davidsarah |
|---|---|---|---|
| Priority: | minor | Milestone: | soon |
| Component: | code-nodeadmin | Version: | 1.7.1 |
| Keywords: | test-needed | Cc: | |
| Launchpad Bug: |
Description
The runner tests do start and stop nodes, but they do so by invoking the CLI in a separate process, so it's not possible to see in the coverage reports which parts of the code are tested.
Change History (6)
comment:1 follow-up: ↓ 2 Changed at 2010-11-27T09:38:46Z by warner
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 4 Changed at 2010-11-27T20:29:51Z by davidsarah
Replying to warner:
this ought to be fixed by the recent import+call+twistd.run() change
That change only removes one level of subprocess invocation. The test itself invokes bin/tahoe as a subprocess (and has to do so in order to avoid consuming the test process). There is also the daemonization on Unix.
Mocking twistd.run would solve the problem of consuming the test process; then you could call the start/stop/restart commands in the same way as the other CLI tests.
comment:3 Changed at 2010-11-28T01:07:25Z by davidsarah
- Milestone changed from soon to 1.9.0
- Owner set to davidsarah
- Status changed from new to assigned
comment:4 in reply to: ↑ 2 Changed at 2010-11-28T01:12:24Z by davidsarah
Replying to davidsarah:
... There is also the daemonization on Unix.
... but that's not relevant to testing coverage of startstop_node.py.
comment:5 Changed at 2011-05-28T19:37:45Z by davidsarah
- Milestone changed from 1.9.0 to soon
comment:6 Changed at 2017-09-19T17:20:49Z by Brian Warner <warner@…>
In 04b34b6/trunk:
this ought to be fixed by the recent import+call+twistd.run() change