Opened at 2010-08-09T21:16:52Z

Closed at 2010-08-09T23:15:45Z

Last modified at 2010-08-12T05:58:27Z

#1160 closed defect (fixed)

viewing web-status of unfinished immutable downloads causes exception

Reported by: zooko Owned by: warner
Priority: critical Milestone: 1.8.0
Component: code-network Version: 1.8β
Keywords: immutable download regression reviewed Cc: warner
Launchpad Bug:

Description

The web-status view (visible at http://$GATEWAY/status) of immutable downloads shows "not impl yet" in the status column. If you click on that to get an exception which ends with: 

          File "/Library/Python/2.6/site-packages/allmydata/web/status.py", line 416, in render_events
            rtt = received - sent
        exceptions.TypeError: unsupported operand type(s) for -: 'NoneType' and 'float'

Attached is an incident report file from such an incident.

Attachments (4)

incident-2010-08-09-140456-fzgnluy.flog.bz2​ (24.9 KB) - added by zooko at 2010-08-09T21:18:08Z.
patch-1-hush-logs.3.diff​ (909 bytes) - added by warner at 2010-08-09T22:28:25Z.
don't log storage requests that arrive after the download is finished
patch-3-tolerate-unretired-DYHB.diff​ (3.7 KB) - added by warner at 2010-08-09T22:30:26Z.
real fix for #1160: tolerate DYHB requests that haven't retired, plus tests
patch-2-fewer-downloadstatus.diff​ (6.3 KB) - added by warner at 2010-08-09T23:10:10Z.
stop creating download-status objects for non-downloaded filenodes (v2)

Download all attachments as: .zip

Change History (9)

Changed at 2010-08-09T21:18:08Z by zooko

comment:1 Changed at 2010-08-09T22:18:00Z by davidsarah

  • Keywords regression added

Changed at 2010-08-09T22:28:25Z by warner

don't log storage requests that arrive after the download is finished

Changed at 2010-08-09T22:30:26Z by warner

real fix for #1160: tolerate DYHB requests that haven't retired, plus tests

comment:2 Changed at 2010-08-09T22:37:38Z by davidsarah

  • Owner set to davidsarah
  • Status changed from new to assigned

Accepting for review.

Changed at 2010-08-09T23:10:10Z by warner

stop creating download-status objects for non-downloaded filenodes (v2)

comment:3 Changed at 2010-08-09T23:12:01Z by davidsarah

  • Keywords reviewed added
  • Owner changed from davidsarah to warner
  • Status changed from assigned to new

Looks good, ok to apply with v2 of second patch.

comment:4 Changed at 2010-08-09T23:15:45Z by Brian Warner <warner@…>

  • Resolution set to fixed
  • Status changed from new to closed

In dc1afc81bbfe95de:

web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160.

Also add a better unit test for it.

comment:5 Changed at 2010-08-12T05:58:27Z by Brian Warner <warner@…>

In [4693/ticket68-multi-introducer]:

web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160.

Also add a better unit test for it.

Note: See TracTickets for help on using tickets.