active immutable downloads are shown on Recent Operations instead of Active Operations

[zooko]

An immutable download is still in-progress, but it appears in Recent Operations instead of Active Operations. By the way, the source code responsible for this may be close to the source code responsible for #1079 (upload of file into dir doesn't appear on Recent Uploads and Downloads).

[zooko]

Should we try to fix this for v1.8.0? I would lean toward "yes".

[warner]

The fix for this will go into source:src/allmydata/immutable/downloader/status.py#L244​ ish (DownloadStatus.get_active). It currently is a stub that always returns False. That should be replaced by something which, I dunno, probably does the same "look for read_events that have a non-None finishtime" check that get_progress uses, so "active" means "has outstanding read() calls".

[francois]

The attached patch implements what Brian proposed in comment:2 and add an appropriate test.

[warner]

I'm ok with this patch. Be aware that if we land the #1170 patches (specifically 1170-p2.diff​) then this one will need to be rewritten, since the download-status data structure changed quite a bit (each event is now an object with attributes, rather than a tuple).

[zooko]

François, could you rewrite your patch to be based on top of Brian's #1170 patches? :-)

[zooko]

Okay I have applied two out of three of Brian's patches, namely c89a464510394089 and 00e9e4e6760021a1. 00e9e4e6760021a1 is the one that was formerly known as 1170-p2.diff​.

[francois]

Replying to warner:

I'm ok with this patch. Be aware that if we land the #1170 patches (specifically 1170-p2.diff​) then this one will need to be rewritten, since the download-status data structure changed quite a bit (each event is now an object with attributes, rather than a tuple).

Well, the download-status data structure are actually changed by 1170-p3.diff​ which is not yet commited in trunk. Anyway, here's an up to date version of the patch: dowloader-status-1172-2.dpatch.

[francois@…]

In 485bfc0fd67ef421:

DownloadStatus?: show active immutable downloads in Active Operations, Fix #1172

[zooko]

Oh look this failed unit tests:

​http://tahoe-lafs.org/buildbot/builders/Kyle%20OpenBSD-4.6%20amd64/builds/390/steps/test-coverage/logs/stdio

[ERROR]: allmydata.test.test_download.Status.test_active

Traceback (most recent call last):
  File "/home/buildbot/tahoe-lafs/Kyle OpenBSD-4.6 amd64/build/src/allmydata/test/test_download.py", line 1267, in test_active
    self.failUnlessEqual(ds.get_active(), True)
  File "/home/buildbot/tahoe-lafs/Kyle OpenBSD-4.6 amd64/build/src/allmydata/immutable/downloader/status.py", line 210, in get_active
    if r_ev["finish_time"] is None:
exceptions.TypeError: tuple indices must be integers, not str

[zooko]

Oh this was my mistake, I should have committed attachment:downloader-status-1172.dpatch​, not attachment:downloader-status-1172-2.dpatch​ . I'll commit a new patch that undoes the effect of attachment:downloader-status-1172-2.dpatch​ and then another patch that has the same effect as attachment:downloader-status-1172.dpatch​. By the way, one thing you can do to make it harder for me to make such mistakes is to use the --ask-deps option to darcs record and specify that a patch depends on another patch. Then when I try to commit your patch, darcs will tell me that I can't do so until I commit that other patch, which will make me realize that I'm trying to commit the wrong patch.

Thanks!

[zooko@…]

In 63fb687a440e99a9:

(The changeset message doesn't reference this ticket)