Opened at 2010-08-12T20:53:57Z
Last modified at 2012-04-01T23:25:14Z
#1173 assigned defect
cancelled downloads are marked incorrectly on the Recent Uploads/Downloads page
| Reported by: | zooko | Owned by: | zooko |
|---|---|---|---|
| Priority: | major | Milestone: | soon |
| Component: | code-frontend-web | Version: | 1.8β |
| Keywords: | immutable download wui unfinished-business regression more-info-needed | Cc: | |
| Launchpad Bug: |
Description
I cancelled a download in progress, and its completeness went to 100% and its state stayed at "fetching segment 1886". This is wrong--if anything its completeness should have stayed at the incomplete percentage that it already was and its state should have changed to "cancelled".
I'm tagging this one with the regression tag, partially because I wonder if we shouldn't delay the Tahoe-LAFS v1.8.0 release to address this one as well as perhaps #1166, #1169, #1171 and (maybe, if there is anything to it) #1170.
Attachments (2)
Change History (14)
Changed at 2010-08-12T20:54:12Z by zooko
comment:1 Changed at 2010-08-13T05:23:20Z by zooko
Changed at 2010-08-13T05:24:03Z by zooko
comment:2 Changed at 2010-08-13T22:18:59Z by warner
Hm, weird. The stuck-at-"fetching segment 1886" is definitely a bug. I'm uncertain about the "completeness=100%" part.. what ought that to say when a download is cancelled? Hm, maybe "cancelled" ?
Some of this needs some reworking.. there's a method that is expected to return a number from 0 to 1 that is used to populate the "completed percentage" field. To replace that with a "cancelled" string, we need to get rid of that method, or allow it to return None, or something.
comment:3 Changed at 2010-08-14T07:03:43Z by zooko
It sounds like these bugs are unimportant enough to leave them in v1.8.0 final. If you agree, please bump them to the "soon" Milestone and remove the "regression" tag.
comment:4 Changed at 2010-09-04T13:13:38Z by francois
- Milestone changed from 1.8.0 to 1.9.0
comment:5 Changed at 2010-10-22T13:40:23Z by zooko
- Milestone changed from 1.9.0 to 1.8.1
Oh, if someone could do it real quick, we could fix this bug in v1.8.1. That would be nice!
comment:6 Changed at 2010-10-24T19:09:45Z by kevan
I couldn't reproduce either of these issues on a fresh checkout of trunk.
When I cancel a download (either by stopping it, if I've downloaded it after using Firefox to access the WUI, or by stopping the curl process, if I've used curl, though I don't see why there should be a difference between the two), I see "Failed (output stopped)" as its status on the status page, and its completeness percentage reflects the amount of data that it had downloaded when I stopped it. This seems like expected behavior to me; at least, it is what I expected to see.
If I try to download part of a file (using, e.g., curl --range 10-10000000) and then stop the download before it can finish, I don't see anything at all about it on the status page. If I let the request complete, I still don't see anything about it on the status page. Weird, arguably buggy behavior, but not what Zooko observed.
Zooko: Can you reproduce these problems? If so, what am I doing wrong to not be able to reproduce them?
comment:7 Changed at 2010-10-24T20:54:44Z by zooko
- Owner set to zooko
- Status changed from new to assigned
comment:8 Changed at 2010-11-02T02:32:00Z by zooko
- Milestone changed from 1.8.1 to soon
comment:9 Changed at 2011-09-02T21:25:02Z by zooko
- Keywords more-info-needed added
Brian changed some of the progress reporting of mutable files in 9756146d61673552 but I suppose this can't have any effect on these immutables that I had trouble with. Anyway, leaving assigned to me to try to reproduce.
comment:10 Changed at 2012-02-02T22:12:27Z by zooko
- Owner zooko deleted
- Status changed from assigned to new
comment:11 Changed at 2012-04-01T23:17:45Z by davidsarah
- Milestone changed from soon to 1.11.0
- Owner set to zooko
Zooko, did you fail to reproduce this, or did you not get chance to try to do so?
comment:12 Changed at 2012-04-01T23:25:14Z by zooko
- Status changed from new to assigned
I haven't tried yet. Will try.
I'm about to attach one that ended because I had asked curl to download only a certain range and it had finished doing so, and it is marked as "idle".