'tahoe backup' should do perform tilde expansion on its '--exclude-from' parameter

[francois]

$ tahoe backup --exclude-from=~/.tahoe/excludes -v ~ tahoe:
Traceback (most recent call last):
  File "/home/francois/dev/tahoe/support/bin/tahoe", line 9, in <module>
    load_entry_point('allmydata-tahoe==1.8.0-r4784', 'console_scripts', 'tahoe')()
  File "/home/francois/dev/tahoe/src/allmydata/scripts/runner.py", line 114, in run
    rc = runner(sys.argv[1:], install_node_control=install_node_control)
  File "/home/francois/dev/tahoe/src/allmydata/scripts/runner.py", line 65, in runner
    config.parseOptions(argv)
  File "/usr/lib/python2.5/site-packages/twisted/python/usage.py", line 231, in parseOptions
    self.subOptions.parseOptions(rest)
  File "/usr/lib/python2.5/site-packages/twisted/python/usage.py", line 219, in parseOptions
    self._dispatch[optMangled](optMangled, arg)
  File "/usr/lib/python2.5/site-packages/twisted/python/usage.py", line 373, in <lambda>
    fn = lambda name, value, m=method: m(value)
  File "/home/francois/dev/tahoe/src/allmydata/scripts/cli.py", line 313, in opt_exclude_from
    raise BackupConfigurationError('Error opening exclude file %r.' % filepath)
allmydata.scripts.cli.BackupConfigurationError: Error opening exclude file '~/.tahoe/excludes'.

[francois]

This patch implements tilde expansion for the tahoe backup --exclude-from option. A unit test is also included.

[davidsarah]

tahoe backup: perform tilde expansion in exclude-from filename. fixes #1241

[davidsarah]

The unit test in patch-1241.dpatch​ didn't really test the right thing, since it would have passed even if abspath_expanduser_unicode hadn't been applied in cli.py.

In exclude-from-tilde-expansion.darcs.patch​, I've changed the unit test to use the 'mock' module to confirm that file is being called with the expected argument.

[davidsarah]

tahoe backup: perform tilde expansion in exclude-from filename (version 2). fixes #1241

[zooko]

I reviewed attachment:exclude-from-tilde-expansion-2.darcs.patch​ and the test in it seems correct. Also the code itself. :-)

[davidsarah]

Fixed in 6eaa7f2356881f16. (There was apparently a problem submitting this changeset to trac, but the trac history has been rebuilt since.)