#1305 closed defect (fixed)
'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS: DIRCAP' (with trailing colon) should work
| Reported by: | davidsarah | Owned by: | warner |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8.2 |
| Component: | code-frontend-cli | Version: | 1.8.1 |
| Keywords: | usability error tahoe-add-alias tahoe-create-alias easy news-done | Cc: | |
| Launchpad Bug: |
Description
tahoe create-alias and tahoe add-alias should accept a trailing colon. Also user errors (including a colon or space in the alias name) should not be reported by an assert.
Attachments (3)
Change History (15)
comment:1 Changed at 2011-01-14T03:19:30Z by davidsarah
- Owner set to davidsarah
- Status changed from new to assigned
- Summary changed from 'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS:' (with trailing colon) should work to 'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS: DIRCAP' (with trailing colon) should work
Changed at 2011-01-14T04:06:48Z by davidsarah
comment:2 follow-up: ↓ 5 Changed at 2011-01-14T04:08:09Z by davidsarah
- Owner davidsarah deleted
- Status changed from assigned to new
This would be an easy patch for someone new to Tahoe to review.
Changed at 2011-01-14T04:18:00Z by davidsarah
CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305
Changed at 2011-01-14T04:36:23Z by davidsarah
CLI: tests for ref #1305 (v2, remove spurious extra arg to create-alias in test)
comment:3 Changed at 2011-01-14T06:41:09Z by david-sarah@…
- Owner set to david-sarah@…
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed at 2011-01-14T08:44:31Z by davidsarah
- Resolution fixed deleted
- Status changed from closed to reopened
Not fixed because it hasn't been applied on trunk.
comment:5 in reply to: ↑ 2 ; follow-up: ↓ 6 Changed at 2011-01-14T23:28:57Z by zooko
Replying to davidsarah:
This would be an easy patch for someone new to Tahoe to review.
Is this supposed to have the review-needed tag now?
comment:6 in reply to: ↑ 5 Changed at 2011-01-15T00:21:57Z by davidsarah
- Keywords review-needed added
- Owner david-sarah@… deleted
- Status changed from reopened to new
Replying to zooko:
Is this supposed to have the review-needed tag now?
Oops, I thought I'd already added one.
comment:7 Changed at 2011-01-17T07:19:00Z by warner
- Owner set to warner
- Status changed from new to assigned
comment:8 Changed at 2011-01-17T09:55:21Z by warner
- Keywords reviewed added; review-needed removed
looks great. pushing now.
comment:9 Changed at 2011-01-17T09:55:44Z by david-sarah@…
- Resolution set to fixed
- Status changed from assigned to closed
In f10a2c0902549684:
comment:10 Changed at 2011-01-17T22:21:52Z by davidsarah
Tests in 5a3acc05b73095b8.
comment:11 Changed at 2011-01-18T00:34:44Z by davidsarah
- Keywords news-needed added; reviewed removed
comment:12 Changed at 2011-01-18T00:35:18Z by davidsarah
- Keywords news-done added; news-needed removed
CLI: tests for ref #1305