#1431 closed enhancement (fixed)
Magic Folder on Windows
| Reported by: | daira | Owned by: | daira |
|---|---|---|---|
| Priority: | major | Milestone: | 1.12.0 |
| Component: | code-frontend-magic-folder | Version: | 1.8.2 |
| Keywords: | windows otf-magic-folder-objective2 magic-folder | Cc: | |
| Launchpad Bug: |
Description
The drop-upload feature (#1429) uses inotify to detect filesystem changes, and therefore works only on Linux. This ticket is about supporting the same feature on Windows, probably using either ReadDirectoryChangesW or NTFS change journals.
Attachments (2)
Change History (23)
comment:1 Changed at 2011-07-25T12:26:16Z by davidsarah
- Type changed from defect to enhancement
Changed at 2011-08-07T20:43:16Z by davidsarah
comment:2 Changed at 2011-08-07T20:43:54Z by davidsarah
- Keywords review-needed added
- Milestone changed from undecided to soon
Changed at 2011-08-08T02:52:09Z by davidsarah
comment:3 follow-up: ↓ 7 Changed at 2011-08-08T03:38:44Z by davidsarah
Known Windows-only issues not mentioned in drop-upload-docs-including-windows.darcs.patch:
- local directories with non-ASCII names are not currently working;
- when a node has drop-upload enabled, it is unresponsive to Ctrl-C (it can only be killed using Task Manager or similar).
comment:4 Changed at 2012-04-01T04:53:42Z by davidsarah
- Milestone changed from soon to 1.11.0
comment:5 Changed at 2012-05-14T01:21:10Z by davidsarah
- Keywords review-needed removed
- Owner set to davidsarah
- Status changed from new to assigned
In addition to the issues noted in comment:3, the patches also need rebasing to current trunk.
comment:6 Changed at 2014-04-12T19:43:39Z by daira
Preliminary rebase: https://github.com/tahoe-lafs/tahoe-lafs/commits/1431-windows-drop-upload. This is not tested at all yet.
comment:7 in reply to: ↑ 3 Changed at 2014-04-12T20:30:23Z by daira
Replying to davidsarah:
- local directories with non-ASCII names are not currently working;
Filed as #2219.
- when a node has drop-upload enabled, it is unresponsive to Ctrl-C (it can only be killed using Task Manager or similar).
Filed as #2218.
These are also now mentioned in the docs.
comment:8 Changed at 2014-04-14T15:40:15Z by daira
Tests are currently failing due to #2220.
comment:9 Changed at 2014-12-02T19:46:50Z by warner
- Component changed from code-frontend to code-frontend-drop-upload
comment:10 Changed at 2015-03-12T23:51:37Z by daira
- Keywords otf-magic-folder added
comment:11 Changed at 2015-03-17T22:14:56Z by daira
- Owner changed from davidsarah to daira
- Status changed from assigned to new
comment:12 Changed at 2015-03-17T22:18:15Z by daira
- Status changed from new to assigned
comment:13 Changed at 2015-04-02T14:54:13Z by daira
- Keywords otf-magic-folder-objective2 added; otf-magic-folder removed
comment:14 Changed at 2015-04-12T22:31:46Z by daira
- Milestone changed from soon to 1.11.0
comment:15 Changed at 2015-05-29T21:00:48Z by daira
Current work-in-progress branch is https://github.com/tahoe-lafs/tahoe-lafs/commits/1431.windows-drop-upload.6.
comment:16 Changed at 2015-06-01T16:11:09Z by daira
- Keywords magic-folder added
Add magic-folder keyword to all drop-upload tickets.
comment:17 Changed at 2015-10-23T21:07:41Z by daira
- Keywords drop-upload removed
- Reporter changed from davidsarah to daira
- Summary changed from drop-upload on Windows to Magic Folder on Windows
comment:18 Changed at 2015-10-30T01:00:54Z by daira
- Resolution set to fixed
- Status changed from assigned to closed
This is landed onto the 2438.magic-folder-stable.5 branch; closing this ticket in favour of more specific tickets.
comment:19 Changed at 2016-01-19T16:20:26Z by meejah
From pairing today, we have concluded:
- only RealTest?.test_alice_bob is failing
- flush_volume() doesn't help, even from an administrator prompt
- the temporary shutil.move() hackery doesn't help
- it seems a bunch of events are doubled (e.g. uploaded counts etc), but this isn't entirely consistent
- when something fails (e.g. assert), there's a (probably spurious) permission denied windows error (admin prompt or not)
- if all the counts are "fixed", then the test passes *but only sometimes*
comment:20 Changed at 2016-03-22T05:02:52Z by warner
- Milestone changed from 1.11.0 to 1.12.0
Milestone renamed
comment:21 Changed at 2016-07-21T21:32:34Z by Brian Warner <warner@…>
In e7fb665/trunk:
Prototype drop-upload implementation for Windows (includes code and test patches from #1429).