PyCrypto 2.4 doesn't build with setuptools

[zooko]

Apparently PyCrypto 2.4 doesn't build with setuptools (or zc.buildout or virtualenv):

​https://bugs.launchpad.net/pycrypto/+bug/881130

This is visible as a failure on FreeStorm's buildslave:

​https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/FreeStorm%20CentOS5-i386/builds/551/steps/test-with-fake-dists/logs/stdio

The characteristic error message is that the build ends with:

error: Setup script exited with error: src/config.h: No such file or directory

Here are my notes about it:

​https://tahoe-lafs.org/pipermail/tahoe-dev/2011-October/006807.html

[warner]

oops, I opened #1575 as a dup. There are some more notes over there.

For 1.9, I've decided to go with the "host binary eggs" fix, since the alternatives are even more gross. That means no code changes need to be made for this. The installability of tahoe-1.9 on systems that don't already have pycrypto available will depend upon volunteers providing us with eggs that we can host, or upon installers being willing to use the workaround of running tahoe's python setup.py build twice.

So this is no longer a 1.9 blocker.

[davidsarah]

This was fixed in 5af3bfda6190b511 (and is also on the 1.9.2 branch), by excluding PyCrypto 2.4 from the versions we allow in src/allmydata/_auto_deps.py. PyCrypto 2.4.1 does not have the packaging bug.