Opened at 2011-11-17T02:11:44Z

Closed at 2011-11-17T22:49:03Z

Last modified at 2012-03-29T23:29:34Z

#1585 closed enhancement (fixed)

restructure the web UI's handling of static files

Reported by: marcusw Owned by: davidsarah
Priority: minor Milestone: 1.9.2
Component: code-frontend-web Version: 1.9.0b1
Keywords: review-needed cleanup wui Cc:
Launchpad Bug:

Description

This patch improves the handling of static resource files in the web ui in these ways:

  • Move static files into separate directory
  • Remove references to no longer used webform_css from root.py and .xhtml files
  • Rename tahoe_css to tahoe.css in the .xhtml files
  • Remove references to individual files from root.py

These changes reduce the code complexity in root.py and make it easier to add/remove static resources to the web interface. They are compatible with the static directory option in tahoe.cfg. Ticket #1579, my ​movebutton patch, is broken by this patch because of the tahoe_css > tahoe.css change.

With these changes applied, all the files in /src/allmydata/web/static are accessible on the web interface with a "GET /filename". Subdirectories are correctly handled. Note that the .js and .css files in /src/allmydata/web must be moved to the new directory when applying this patch. This should be done using your version control system, and is not included in the patch (but it is in the git branch).

These changes are available as a ​branch on github and as a .diff attachment to this ticket.

Attachments (2)

staticstruct.diff​ (16.2 KB) - added by marcusw at 2011-11-17T02:11:56Z.
1585-webui.darcs.patch​ (75.1 KB) - added by marcusw at 2011-11-17T21:56:28Z.
Got my darcs working; here's a patch for these changes

Download all attachments as: .zip

Change History (5)

Changed at 2011-11-17T02:11:56Z by marcusw

comment:1 Changed at 2011-11-17T03:11:09Z by davidsarah

  • Keywords cleanup wui added
  • Milestone changed from undecided to 1.10.0
  • Owner set to davidsarah
  • Status changed from new to assigned
  • Summary changed from Patch/branch to restructure the web ui's handling of static files to restructure the web UI's handling of static files

Assigning to me to convert to a darcs patch.

Changed at 2011-11-17T21:56:28Z by marcusw

Got my darcs working; here's a patch for these changes

comment:2 Changed at 2011-11-17T22:49:03Z by warner

  • Resolution set to fixed
  • Status changed from assigned to closed

looks good! landed in 0ed6260a3c1bf67b. Thanks!

comment:3 Changed at 2012-03-29T23:29:34Z by davidsarah

  • Milestone changed from 1.10.0 to 1.9.2
Note: See TracTickets for help on using tickets.