#159 closed defect (invalid)

extra newline in .furl file breaks furls, and the resulting diagnostics are not user friendl

Reported by: zooko Owned by: zooko
Priority: major Milestone: 0.6.1
Component: code-nodeadmin Version: 0.6.0
Keywords: Cc:
Launchpad Bug:

Description

Sebastian and I accidentally left an extra newline at the end of our introducer.furl file, so somewhere deep in the node there was an AttributeError? involving None.

Perhaps the node should be tolerant by stripping the contents of .furl files. Certainly it should check those contents for correct formatting early and report to the user explicitly about it.

Change History (5)

comment:1 Changed at 2007-10-01T20:08:25Z by zooko

  • Status changed from new to assigned

comment:2 Changed at 2007-10-02T21:32:14Z by zooko

Tried to reproduce this, and it works fine with an extra newline.

So I think the real problem was that I used notepad.exe (on Windows), and it left dos-style newlines ("\r\n") instead of unix-style. Just a guess. I'll try to reproduce that next.

comment:3 Changed at 2007-10-11T08:47:59Z by warner

strip() ought to remove both \r and \n, right?

comment:4 Changed at 2007-10-13T20:15:33Z by zooko

  • Resolution set to invalid
  • Status changed from assigned to closed

I'm closing this as unreproducible.

comment:5 Changed at 2007-10-15T20:58:16Z by zooko

For the record, I suspect that what really happened was that notepad.exe appended ".txt" to the file when it saved it, leaving "introducer.furl" empty.

Note: See TracTickets for help on using tickets.