Opened at 2012-02-14T21:34:33Z

Closed at 2019-07-25T12:57:54Z

#1677 closed defect (wontfix)

add buildbot step to run "make code-checks"

Reported by: davidsarah Owned by: davidsarah
Priority: normal Milestone: soon (release n/a)
Component: dev-infrastructure Version: 1.9.1
Keywords: code-checks buildbot Cc:
Launchpad Bug:

Description (last modified by warner)

... or replace the pyflakes step (since make code-checks runs pyflakes among other things).

This requires ensuring that make code-checks returns a correct exit code and does not have too many false-positives.

Change History (4)

comment:1 Changed at 2012-02-14T21:34:46Z by davidsarah

  • Status changed from new to assigned

comment:2 Changed at 2012-06-04T17:38:20Z by davidsarah

  • Priority changed from major to normal

comment:3 Changed at 2015-03-20T19:59:05Z by warner

  • Description modified (diff)

Let's also make sure the output is not too noisy. Ideally each program it runs would emit no output for success. The "build" make-dependency dumps an awful lot of output, every time, and a bunch of the tools announce each module they're checking, which is a drag.

A buildstep which knew how to parse out the actual problems could help.

comment:4 Changed at 2019-07-25T12:57:54Z by exarkun

  • Resolution set to wontfix
  • Status changed from assigned to closed

Buildbot has been decommissioned. TravisCI and CircleCI both run tox -e codechecks which seems roughly equivalent to make code-checks (it doesn't run check-interfaces but check-interfaces reports a bunch of noise and then bails out in my dev environment so I'm not sure we're missing much).

Note: See TracTickets for help on using tickets.