Opened at 2012-03-08T17:19:28Z
Closed at 2012-03-14T02:57:59Z
#1682 closed defect (fixed)
various links in comments, docs, and tahoe.cfg should be https
| Reported by: | davidsarah | Owned by: | davidsarah |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.2 |
| Component: | code-frontend-web | Version: | 1.9.1 |
| Keywords: | easy wui security reviewed | Cc: | |
| Launchpad Bug: |
Description
It is currently to http://tahoe-lafs.org.
Attachments (4)
Change History (17)
comment:1 Changed at 2012-03-08T17:20:30Z by davidsarah
- Owner set to davidsarah
- Priority changed from major to minor
- Status changed from new to assigned
Changed at 2012-03-09T00:04:23Z by davidsarah
comment:2 Changed at 2012-03-09T00:06:14Z by davidsarah
- Keywords review-needed added
- Milestone changed from soon to 1.9.2
- Owner changed from davidsarah to zooko
- Status changed from assigned to new
Changed at 2012-03-13T03:12:47Z by from_pycon
Changed at 2012-03-13T03:13:02Z by from_pycon
comment:3 follow-up: ↓ 4 Changed at 2012-03-13T03:15:19Z by from_pycon
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed at 2012-03-13T03:56:29Z by davidsarah
- Keywords reviewed added; review-needed removed
Replying to from_pycon:
The patch seems sane. It doesn't https-ify all the links in the tahoe-lafs codebase, but it does what the ticket title says.
I looked for other links that should be httpsified, and didn't find any. (Note that the URLs that specify protocol versions should not be httpsified.) Did I miss anything?
comment:5 in reply to: ↑ 4 Changed at 2012-03-13T06:08:42Z by from_pycon
Replying to davidsarah:
Replying to from_pycon:
The patch seems sane. It doesn't https-ify all the links in the tahoe-lafs codebase, but it does what the ticket title says.
I looked for other links that should be httpsified, and didn't find any. (Note that the URLs that specify protocol versions should not be httpsified.) Did I miss anything?
I was thinking of the links in the manpage, or the links in the find_links list of setup.cfg.
Changed at 2012-03-13T20:32:38Z by davidsarah
Update more links from http: to https: in documentation and comments. Also update find_links URLs in setup.cfg to https://tahoe-lafs.org. The latter is not just a doc change; look out for compatibility problems.
comment:6 Changed at 2012-03-13T20:35:05Z by davidsarah
- Keywords review-needed added; reviewed removed
- Owner changed from zooko to from_pycon
comment:7 Changed at 2012-03-13T23:04:28Z by david-sarah@…
In aebaa838da7370ac:
comment:8 Changed at 2012-03-13T23:04:28Z by david-sarah@…
- Resolution set to fixed
- Status changed from new to closed
In aaee828abb77bd89:
comment:9 Changed at 2012-03-13T23:28:37Z by davidsarah
- Resolution fixed deleted
- Status changed from closed to reopened
more-httpsification.darcs.patch hasn't been reviewed or committed yet.
comment:10 Changed at 2012-03-14T00:00:49Z by davidsarah
- Summary changed from link to tahoe-lafs.org on the WUI Welcome page should be https to various links in comments, docs, and tahoe.cfg should be https
comment:11 Changed at 2012-03-14T01:35:55Z by from_pycon
- Owner changed from from_pycon to davidsarah
- Status changed from reopened to new
Hm! I checked a small subset of the re-written links and they seem to point to the correct place. Maybe this calls for a small script which will automatically check these links and whether they point to the same content as the previous links.
I'll move the owner back to your davidsarah.
comment:12 Changed at 2012-03-14T02:57:42Z by davidsarah
I checked the ones other than https://tahoe-lafs.org manually. So, counting comment:11 as a review.
comment:13 Changed at 2012-03-14T02:57:59Z by davidsarah
- Keywords reviewed added; review-needed removed
- Resolution set to fixed
- Status changed from new to closed
The patch seems sane. It doesn't https-ify all the links in the tahoe-lafs codebase, but it does what the ticket title says.
I also attached two patches in patch(1) format, since the darcs patch format is too groovy.
They were created using: darcs diff -u -n 1 > fix-1682_1.git.patch