Context Navigation

classes in different modules shouldn't have the same name, it's confusing

Reported by:	davidsarah	Owned by:	warner
Priority:	minor	Milestone:	1.9.2
Component:	code	Version:	1.9.1
Keywords:	cleanup reviewed	Cc:
Launchpad Bug:

Description

E.g.

$ grep -Rn 'class CheckAndRepairResults' src
src/allmydata/web/check_results.py:272:class CheckAndRepairResults(CheckerBase, rend.Page, ResultsBase):
src/allmydata/check_results.py:74:class CheckAndRepairResults:

Attachments (1)

rename.diff (7.8 KB) - added by warner at 2012-04-03T02:50:02Z.: rename the web side to -Renderer

Download all attachments as: .zip

Change History (5)

Changed at 2012-04-03T02:50:02Z by warner

Attachment rename.diff added

rename the web side to -Renderer

comment:1 Changed at 2012-04-03T03:00:13Z by warner

Keywords review-needed added
Owner changed from somebody to davidsarah

comment:2 Changed at 2012-04-03T03:03:44Z by davidsarah

Keywords reviewed added; review-needed removed
Milestone changed from undecided to 1.9.2
Owner changed from davidsarah to warner

Looks good, thanks! (I didn't check that all uses were renamed, but pyflakes will do that.)

comment:3 Changed at 2012-04-03T03:06:04Z by Brian Warner <warner@…>

Resolution set to fixed
Status changed from new to closed

In bf390cca4b51cfef:

Rename web CheckResults? to -Renderer, to avoid confusion. Closes #1705.

This avoids the name collision between the actual results
objects (defined in allmydata.check_results) and the code that renders
these objects into HTML (defined in allmydata.web.check_results). Only
the web-side objects were renamed.

comment:4 Changed at 2012-04-03T03:06:31Z by Brian Warner <warner@…>