S3 backend: /storage page gives AttributeError: 'NoneType' object has no attribute 'get_state'

[davidsarah]

The 'Storage Server' page (/storage) of a node running the S3 backend gives a nevow traceback with the following exception:

/home/customer/LAFS_source/src/allmydata/web/storage.py, line 90 in data_last_complete_bucket_count
88
89    def data_last_complete_bucket_count(self, ctx, data):
90        s = self.storage.bucket_counter.get_state()
91        count = s.get("last-complete-bucket-count")
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'get_state'

This happens because the S3 backend doesn't support crawlers, so it doesn't initialize the bucket_counter state. This doesn't affect the LAE servers because they don't run a web interface, but it should be fixed in order to merge the S3 backend.

[davidsarah]

The leasedb+cloud backend merge supports crawlers, so this ticket is unneeded.

[davidsarah]

Oh but wait, why didn't this cause a failing test?

[daira]

The WebStatusWithMockCloudBackend class in test_storage.py now tests this (on the cloud-rebased2 branch).