Opened at 2012-06-22T02:57:20Z
Closed at 2013-01-02T02:28:21Z
#1777 closed enhancement (fixed)
cleanups to backupdb tests
| Reported by: | zooko | Owned by: | warner |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.10.0 |
| Component: | code-frontend | Version: | 1.9.1 |
| Keywords: | test cleanup | Cc: | |
| Launchpad Bug: |
Description (last modified by davidsarah)
This cleanup patch removes complexity in the backupdb tests that was caused by needing to handle the case where pysqlite is not available. We now depend on Python 2.5 which includes pysqlite in the standard lib.
Attachments (1)
Change History (8)
Changed at 2012-06-22T02:58:48Z by zooko
comment:1 Changed at 2012-06-22T02:59:11Z by zooko
- Keywords review-needed added
comment:2 Changed at 2012-09-04T23:20:21Z by davidsarah
- Component changed from unknown to code-frontend
- Description modified (diff)
- Keywords cleanup added; mutable removed
- Owner changed from davidsarah to zooko
- Summary changed from cleanups to tests and mutables for 1.10 to cleanups to backupdb tests
Reviewed. Please check it applies/tests cleanly and land it for 1.10.
The description of this ticket was really vague and not specific to the attached patch. One ticket per batch of closely related cleanups, please!
comment:3 Changed at 2012-09-05T02:19:44Z by zooko
- Keywords reviewed added; review-needed removed
comment:4 Changed at 2012-10-26T01:27:09Z by davidsarah
Needs rerecording in git.
comment:5 Changed at 2012-12-13T17:25:31Z by davidsarah
- Priority changed from minor to normal
comment:6 Changed at 2012-12-20T17:59:36Z by warner
- Owner changed from zooko to warner
- Status changed from new to assigned
I'll land this.
comment:7 Changed at 2013-01-02T02:28:21Z by davidsarah
- Keywords reviewed removed
- Resolution set to fixed
- Status changed from assigned to closed
An equivalent change was already made in a1a1b5bf8a6e1a09.
That commit, although made before 1.9.2 was released, was not in the 1.9.2 branch (which is unsurprising since it is a cleanup and 1.9.2 was a point release), so 1.10 will be the first release to have it.
I intend to attach more patches as I generate them.