Opened at 2012-07-01T17:16:38Z
Last modified at 2014-04-14T23:06:42Z
#1784 closed defect
add happiness count to check reports and fix the definition of needs-rebalancing — at Version 11
Reported by: | davidsarah | Owned by: | daira |
---|---|---|---|
Priority: | normal | Milestone: | 1.10.1 |
Component: | code-frontend-web | Version: | 1.9.1 |
Keywords: | usability check verify repair servers-of-happiness blocks-release review-needed | Cc: | |
Launchpad Bug: |
Description (last modified by daira)
Change History (11)
comment:1 Changed at 2012-07-01T17:16:46Z by davidsarah
- Owner set to davidsarah
- Status changed from new to assigned
comment:2 Changed at 2012-07-01T17:18:16Z by davidsarah
- Summary changed from add servers-of-happiness to check reports to add happiness count to check reports
comment:3 Changed at 2012-07-01T23:10:16Z by david-sarah@…
comment:4 Changed at 2012-07-16T16:33:55Z by david-sarah@…
comment:5 Changed at 2013-02-15T03:37:00Z by davidsarah
- Keywords verify servers-of-happiness added
comment:6 Changed at 2013-03-26T05:43:41Z by davidsarah
- Milestone changed from 1.10.0 to 1.11.0
comment:7 Changed at 2013-04-18T22:50:13Z by Daira Hopwood <david-sarah@…>
In b06f8cd8d03a6239:
comment:8 Changed at 2013-04-18T23:02:49Z by daira
Copying this from ticket:1115#comment:27, with minor updates:
... the value of needs-rebalancing is computed inconsistently between checker.py and filenode.py. In checker.py it is computed as:
# The file needs rebalancing if the set of servers that have at least # one share is less than the number of uniquely-numbered shares # available. # TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784. needs_rebalancing = bool(good_share_hosts < len(verifiedshares))
In filenode.py it is computed as
# TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784. needs_rebalancing = bool(len(sm) >= verifycap.total_shares)
where len(sm) is equal to count-shares-good. I don't understand this latter definition at all, it looks completely wrong. The definition in checker.py is more subtly wrong because it credits servers that only have duplicated shares as contributing to existing balance. The correct definition should be something like 'iff the happiness count is less than the number of uniquely-numbered good shares available'.
I propose to change filenode.py and checker.py to be consistent, and to both use the happiness-based definition above.
comment:9 Changed at 2013-04-18T23:04:32Z by daira
- Owner changed from davidsarah to daira
- Status changed from assigned to new
- Summary changed from add happiness count to check reports to add happiness count to check reports and fix the definition of needs-rebalancing
comment:10 Changed at 2013-04-18T23:04:44Z by daira
- Status changed from new to assigned
comment:11 Changed at 2013-04-18T23:05:17Z by daira
- Description modified (diff)
In 5532/1.9.2: