Opened at 2012-07-02T19:19:36Z

Closed at 2013-04-09T11:27:32Z

Last modified at 2013-04-10T01:58:54Z

#1785 closed defect (fixed)

type error in ServerMap.copy?

Reported by: davidsarah Owned by: warner
Priority: normal Milestone: 1.10.0
Component: code-mutable Version: 1.9.1
Keywords: typeerror mutable Cc:
Launchpad Bug:

Description

ServerMap​ has an update_data attribute that is not set on the copy returned by ServerMap.copy. I don't know whether this case is ever exercised.

Change History (5)

comment:1 Changed at 2012-07-02T19:20:34Z by davidsarah

  • Owner set to kevan

comment:2 Changed at 2012-12-13T17:08:27Z by davidsarah

  • Owner changed from kevan to davidsarah
  • Status changed from new to assigned

comment:3 Changed at 2013-04-04T16:37:21Z by warner

  • Owner changed from davidsarah to warner
  • Status changed from assigned to new

Our plan is to add: 

        s.update_data = copy.deepcopy(self.update_data)

to line 136 in mutable/servermap.py.

It's probably unused, and the update_data contains only inert data (e.g. no IServer references), so it should be safe, and should protect us from future confusion.

comment:4 Changed at 2013-04-09T11:27:32Z by Brian Warner <warner@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 4751a468408d8cc8:

ServerMap?.copy(): deepcopy .update_data too. Closes #1785.

This was apparently unused, but good to copy for completeness. Tests
pass with and without the change.

comment:5 Changed at 2013-04-10T01:58:54Z by daira

Reviewed, +1.

Note: See TracTickets for help on using tickets.