#180 closed defect (fixed)

make test-clean gives false alarms

Reported by: zooko Owned by: warner
Priority: minor Milestone: 0.6.1
Component: packaging Version: 0.6.0
Keywords: buildbot test Cc:
Launchpad Bug:

Description

This seems like a trivial problem to fix, but I can't figure out which trivial fix is the right one, so I'm opening this ticket. The problem is that make test-clean turns the buildbot red if new Python files have been added, e.g. http://allmydata.org/buildbot/builders/clean/builds/414

One trivial fix would be to make && make clean before beginning the test, but that would allow uncleaned messes to pass the test. Another would be to exclude *.pyc files from consideration, which raises the question of whether we should exclude all of the .darcs-boringfile regexes from consideration, which raises the question of whether we shouldn't make test-clean be a Python script like test-darcs-boringfile is instead of a GNUmake script, which raises issue #179. ;-)

Change History (3)

comment:1 Changed at 2007-10-15T20:50:25Z by zooko

  • Owner changed from somebody to warner

Brian helped me realize that the reason this cruft is appearing is that the new find_trial.py script gets executed whenever the Makefile gets evaluated. After he gets back from lunch he'll probably refactor it to execute find_trial.py only in a make command and thus fix this ticket...

comment:2 Changed at 2007-10-15T22:07:58Z by warner

  • Status changed from new to assigned

done, in 1e04ad47208d71a6.

comment:3 Changed at 2007-10-15T22:08:26Z by warner

  • Milestone changed from 0.7.0 to 0.6.1
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.