#1800 closed defect (fixed)

storage indices are sometimes logged as binary

Reported by: davidsarah Owned by: warner
Priority: normal Milestone: 1.10.1
Component: code-mutable Version: 1.9.2
Keywords: logging mutable usability easy Cc:
Launchpad Bug:

Description (last modified by daira)

In 1670#comment:19, there's an incident log that contains binary storage indices in the (human-readable) log message. They should be zbase32.

The offending code starts at src/allmydata/mutable/publish.py@5585#L1129, but the bug is on line 1138 (it should be base32.b2a(other_roothash)).

Change History (4)

comment:1 Changed at 2012-09-05T03:19:05Z by davidsarah

  • Keywords easy added

comment:2 Changed at 2013-10-31T16:02:46Z by daira

  • Description modified (diff)
  • Milestone changed from soon to 1.11.0

Zooko already had a patch for this (see #1670).

comment:3 Changed at 2014-09-02T17:59:56Z by warner

  • Owner changed from zooko to warner
  • Status changed from new to assigned

comment:4 Changed at 2014-09-02T20:36:17Z by Brian Warner <warner@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45adde71808bc27d41b5bc77a963184957e9b247/trunk:

publish.py: log roothash in base32, not binary

Closes ticket:1800

Note: See TracTickets for help on using tickets.