#1908 closed defect (fixed)
drop the darcsver egg
| Reported by: | davidsarah | Owned by: | zooko |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.10.0 |
| Component: | packaging | Version: | 1.9.2 |
| Keywords: | git darcsver packaging cleanup setuptools | Cc: | |
| Launchpad Bug: |
Description (last modified by daira)
darcsver-1.7.2.egg is probably no longer needed now that we're doing the 1.10 release completely in git.
Change History (7)
comment:1 Changed at 2013-02-16T19:25:31Z by davidsarah
- Keywords setuptools added
comment:2 Changed at 2013-02-16T19:29:53Z by davidsarah
Use this branch to reproduce the above error: https://github.com/davidsarah/tahoe-lafs/commits/1908-drop-darcsver-egg
comment:3 Changed at 2013-02-18T19:16:51Z by zooko
We should replace the functionality that darcsver used to provide. The best way to do this would probably be to use Brian's "versioneer" (https://blog.mozilla.org/warner/2012/01/31/version-string-management-in-python-introducing-python-versioneer/), like pycryptopp does (https://tahoe-lafs.org/trac/pycryptopp/browser/git/setup.py?annotate=blame&rev=f789ed951b49b33e7cc49d16fdc8b398f7ec7223).
comment:4 Changed at 2013-03-19T23:18:46Z by Brian Warner <warner@…>
- Resolution set to fixed
- Status changed from new to closed
In 19b2ef9764bdb201:
comment:5 Changed at 2013-03-19T23:20:24Z by warner
- Milestone changed from undecided to 1.10.0
comment:6 Changed at 2013-03-20T21:33:58Z by davidsarah
Nice to see the automated ticket-close messages working again!
comment:7 Changed at 2014-03-05T02:53:40Z by daira
- Description modified (diff)

I thought this was an easy ticket, but it turns out that removing darcsver-1.7.2.egg results in setup.py update_version breaking (even in a git checkout), with this error:
$ python setup.py build /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'versionfiles' warnings.warn(msg) running update_version Traceback (most recent call last): File "setup.py", line 468, in <module> **setup_args File "/usr/lib/python2.7/distutils/core.py", line 152, in setup dist.run_commands() File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands self.run_command(cmd) File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command cmd_obj.run() File "setup.py", line 341, in run target = self.distribution.versionfiles[0] AttributeError: Distribution instance has no attribute 'versionfiles'It's easy enough to tolerate lack of the 'versionfiles' attribute in setup.py, but I think that's the wrong fix.