Opened at 2007-10-27T07:22:57Z
Closed at 2008-06-05T19:29:11Z
#194 closed enhancement (duplicate)
README.w32
Reported by: | ghazel | Owned by: | zooko |
---|---|---|---|
Priority: | minor | Milestone: | 1.2.0 |
Component: | documentation | Version: | 0.7.0 |
Keywords: | Cc: | Michael, Booker, booker, robk | |
Launchpad Bug: |
Description
As discovered at the hack-a-thon, zfec requies c99 and MS never plans to support c99. This patch (should) make zfec c89 compliant without any significant change in runtime or memory behevaiour (yay alloca).
You should probably run unittests if you have any. I was able to compile and run tahoe just fine, but that is by no means a full test.
Attachments (1)
Change History (14)
Changed at 2007-10-27T07:23:17Z by ghazel
comment:1 Changed at 2007-10-29T16:56:26Z by zooko
- Owner changed from zooko to ghazel
Thank you for the patch! I'll accept it into the source code immediately, but there are a few other things we should do:
- Can you give me a reference for Microsoft's position on C99? (That still makes me sad. I think C99 is nice.) Anyway, I'd like to have a link to Microsoft's statement on it to reference in the future. Also, I suppose, if their stated reason is "lack of requests from customers", then I guess I could as a paying customer of Microsoft developer tools request that they add C99 support.
- We could use a Windows buildslave, see http://allmydata.org/trac/tahoe/ticket/7#comment:17
- Somebody should update the README and the README.w32 to explain how you can, in fact, build tahoe with the Microsoft tools.
Thanks!
comment:2 Changed at 2007-12-18T00:04:15Z by zooko
We now have e-mail from trac working, so ghazel will hopefully receive an e-mail note.
comment:3 Changed at 2007-12-18T00:05:49Z by zooko
- Cc Michael Booker booker added
Mike Booker has agreed to do #3 -- update the READMEs to explain how to build with Microsoft tools. Mike -- is that right? You are going to do this?
comment:4 Changed at 2007-12-20T18:37:51Z by zooko
- Milestone changed from undecided to 0.7.0
- Owner changed from ghazel to booker
- Version changed from unknown to 0.7.0
comment:5 Changed at 2007-12-20T18:42:39Z by zooko
- Summary changed from c89 patch for zfec to README.w32
My second request -- a Windows buildslave -- has been satisfied. Although note that this is a Windows buildslave which uses cygwin build tools. There is an open ticket to create a Windows buildslave that uses Microsoft build tools: #230.
My first request -- a link to Microsoft's official position on supporting C99 -- remains unresolved. I would like to be able to write an effective mail saying "I am a Microsoft customer, and I request this feature.", and to facilitate other people who want C99 support to do the same.
Mike is working on the third request -- updating the README.w32. (Possibly he will even create a README.w32.VisualStudio so that people who are going to do the all-cygwin way and the cygwin-tools-to-build-native-objects way can have their own path through the instructions.)
comment:6 Changed at 2008-01-07T05:44:14Z by zooko
I'm going to update our docs to explain that building with Microsoft tools is currently not supported because of pyOpenSSL.
comment:7 Changed at 2008-01-08T17:26:07Z by zooko
- Milestone changed from 0.7.0 to 0.7.1
RobK made some good updates to [docs:README.win32] yesterday. It needs a lot more work (structure -- separating cygwin from Windows-native, probably, and perhaps HTML-formatting), but I'm bumping this ticket out of 0.7.0 now.
comment:8 Changed at 2008-01-23T02:57:16Z by zooko
- Cc robk added
- Milestone changed from 0.7.1 to 0.8.0 (Allmydata 3.0 Beta)
Documenting our build process is one of those things that isn't actually a requirement for the Allmydata 3.0 product, but which we should not put off, so I'm putting this ticket into 0.8.0.
comment:9 Changed at 2008-03-08T01:39:28Z by zooko
- Owner changed from booker to robk
Assigning to RobK. Rob: feel free to bump it to a future Milestone, close it, etc. as appropriate.
comment:10 Changed at 2008-03-08T02:36:00Z by zooko
- Milestone changed from 0.8.0 (Allmydata 3.0 Beta) to 0.9.0 (Allmydata 3.0 final)
comment:11 Changed at 2008-03-12T19:01:05Z by zooko
- Milestone changed from 0.9.0 (Allmydata 3.0 final) to 0.10.0
comment:12 Changed at 2008-05-29T22:47:02Z by zooko
- Component changed from code-encoding to documentation
- Owner changed from robk to zooko
also fix up (or kill) docs/install-details.html
comment:13 Changed at 2008-06-05T19:29:11Z by zooko
- Milestone changed from 1.1.0 to 1.1.1
- Resolution set to duplicate
- Status changed from new to closed
For the moment I have removed README.win32 and docs/install-detailed.html from the source tree and I'm bumping this issue to 1.1.1. Actually I'm closing this as a duplicate of #282 (more detailed and targeted docs about installing from source).
c89 diff