Opened at 2013-05-02T00:26:57Z

Closed at 2015-01-21T01:36:32Z

#1961 closed defect (fixed)

WUI: accessibility problem with node status in new Welcome page

Reported by: daira Owned by: warner
Priority: major Milestone: 1.10.1
Component: code-frontend-web Version: 1.10.0
Keywords: wui accessibility regression blocks-release Cc:
Launchpad Bug:

Description (last modified by RedEmerald)

On 02/05/13 00:16, Greg Troxel wrote:

The up/down-ness of nodes is indicated by a green vs red circle, which is gratuitously unfriendly to people with color vision issues and/or B&W displays (yes, I have sparcstation ELC handy, but no I haven't tried to run a browser on it and look at the weclome page).

I would suggest leaving the green circle and making the down icon be a red X, basically the logical and of a big X and the circle, so it has similar visual feel, and is distinguishable w/o color.

It's unfortunate that I missed this, given that I fixed it for the Introducer and Helper status (they say "Not Connected"). My bad.

Change History (16)

comment:1 Changed at 2013-05-10T02:29:07Z by RedEmerald

  • Description modified (diff)

Much love for this

comment:2 Changed at 2013-08-28T16:38:52Z by daira

  • Keywords blocks-release added
  • Milestone changed from soon to 1.11.0

comment:3 Changed at 2013-12-05T16:12:56Z by nejucomo

  • Owner changed from daira to nejucomo

Daira and I worked on this at the last summit. I have a branch that's almost ready for a pull request.

comment:4 Changed at 2013-12-31T00:32:49Z by zooko

What's the status of this ticket? I guess, from reading the comment history, that it is blocked on nejucomo posting a pull request.

comment:5 Changed at 2014-09-02T18:24:48Z by warner

nejucomo is going to locate the branch for this, then assign to me for review and landing.

comment:7 Changed at 2014-09-07T23:13:48Z by nejucomo

I rebased (with rename appending _1) the above onto the latest master:

​https://github.com/nejucomo/tahoe-lafs/tree/1961-welcome-accessibility_1

I can now run setup.py test (within a virtualenv) and all tests pass except for some skips and some expected failures: 

Ran 1140 tests in 436.003s

PASSED (skips=5, expectedFailures=3, successes=1132)

However, when I start a node the images are broken links, so I consider the unit tests to have insufficient coverage for a pull-request. Focusing on that now.

comment:8 follow-up: Changed at 2014-09-08T18:17:01Z by warner

minor nit, could we use "-1" instead of "_1" for future branch-name suffixes? Easier to type.

comment:9 in reply to: ↑ 8 Changed at 2014-09-08T21:32:44Z by daira

Replying to warner:

minor nit, could we use "-1" instead of "_1" for future branch-name suffixes? Easier to type.

That's the convention we use at LeastAuthority, but I'm open to changing it.

Last edited at 2014-09-08T21:32:56Z by daira (previous) (diff)

comment:10 Changed at 2014-09-23T17:24:29Z by warner

nejucomo said he will work on this on this coming friday. Still on track for 1.11

comment:12 Changed at 2014-11-25T17:37:04Z by daira

Blocked because of the licensing issue described at ​https://github.com/tahoe-lafs/tahoe-lafs/pull/110#issuecomment-56603567 (we need a connected-not-configured icon with compatible licensing).

comment:13 Changed at 2015-01-21T00:46:21Z by nejucomo

Okay, I've added a new PR: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/136

This one is a single commit with all new icons I created and place into the public domain.

comment:14 Changed at 2015-01-21T00:49:09Z by nejucomo

  • Keywords review-needed added

comment:15 Changed at 2015-01-21T01:18:19Z by warner

  • Owner changed from nejucomo to warner
  • Status changed from new to assigned

On it, I'll see if I can tighten up the layout CSS too.

comment:16 Changed at 2015-01-21T01:36:32Z by warner

  • Keywords review-needed removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Done, in cfec3ef.

Note: See TracTickets for help on using tickets.